phi 4 multimodal training version 1 ( with limitations ) #1555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikg4
reviewed
Mar 18, 2025
nikg4
reviewed
Mar 18, 2025
nikg4
reviewed
Mar 18, 2025
nikg4
reviewed
Mar 18, 2025
nikg4
reviewed
Mar 18, 2025
nikg4
reviewed
Mar 18, 2025
nikg4
reviewed
Mar 18, 2025
src/oumi/datasets/chat_templates/phi4-multimodal-instruct.jinja
Outdated
Show resolved
Hide resolved
nikg4
reviewed
Mar 18, 2025
nikg4
reviewed
Mar 20, 2025
optas
changed the title
nikg4
reviewed
Mar 20, 2025
| @override | ||
| def ignore_features(self) -> list[str]: | ||
| """Returns a list of keys of features to ignore from feeding the model.""" | ||
| return self._ignore_features if self._ignore_features else [] |
There was a problem hiding this comment.
Consider returning a shallow copy. Just to make sure that external users can't mutate our member variables.
return copy.copy(self._ignore_features) if self._ignore_features else []
nikg4
reviewed
Mar 20, 2025
| @@ -75,6 +79,7 @@ def __init__( | |||
| self._worker_processor.image_processor | |||
| ) | |||
| self._label_ignore_index: Optional[int] = label_ignore_index | |||
| self._ignore_features: Optional[list[str]] = ignore_features | |||
There was a problem hiding this comment.
Consider making our own private copy. Just to make sure that external users can't mutate our member variable.
self._ignore_features: Optional[list[str]] = copy.copy(ignore_features) if ignore_features else []
nikg4
approved these changes
Mar 20, 2025
nikg4
reviewed
Mar 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds the necessary changes for SFT training (vision/text-only) with phi-4 in Oumi.
Given that we are using here the
vision_language_with_paddingwe are limited to size batch 1, and we cannot accommodate multi-image training.Related issues
Towards OPE-1102
Before submitting
Reviewers
At least one review from a member of
oumi-ai/oumi-staffis required.